Closed pyrsson closed 6 months ago
Welcome @pyrsson!
It looks like this is your first PR to kubernetes-sigs/kubectl-validate 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/kubectl-validate has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
LGTM but i wonder if we can have a test for that 🤔
LGTM but i wonder if we can have a test for that 🤔
I could give it a go, but I'm not entirely sure what the tests should cover. My understanding is that there is fairly little value in writing tests for library functionality, but I could be wrong.
Do you have a suggestion for what to test in kubeconfig.go
?
/lgtm /approve
From a glance it looks like adding a good test for this requires infra we dont have to stand up a fake cluster requiring the plugin. Since this is a single line addition simply to link the library I think it is ok to add
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alexzielenski, pyrsson
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds support for clusters using any of the client-go auth plugins like oidc based on these docs: client-go examples
Fixes validation of CRDs when connected to a cluster with oidc for example:
Which issue(s) this PR fixes:
Didn't open an issue, hope that's ok.
Special notes for your reviewer:
First ever contribution, please let me know if there's something I missed or need to change.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: