search

kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.14k stars 6.47k forks source link

coredns version is hardcoded for release-2.21. For kubeadm 1.23 it should be 1.8.6 not 1.9.6 #10244

Closed prtkdave closed 9 months ago

prtkdave commented 1 year ago

coredns version is hardcoded for release-2.21. For kubeadm 1.23 it should be 1.8.6 not 1.9.6

coredns_version: "v1.9.3" coredns_image_is_namespaced: "{{ (coredns_version is version('v1.7.1','>=')) }}"

coredns_image_repo: "{{ kube_image_repo }}{{'/coredns/coredns' if (coredns_image_is_namespaced | bool) else '/coredns' }}" coredns_image_tag: "{{ coredns_version if (coredns_image_is_namespaced | bool) else (coredns_version | regex_replace('^v', '')) }}" https://github.com/kubernetes-sigs/kubespray/blob/release-2.21/roles/download/defaults/main.yml

Environment:

onprem

NAME="Ubuntu" VERSION="20.04.3 LTS (Focal Fossa)" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu 20.04.3 LTS" VERSION_ID="20.04" HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" VERSION_CODENAME=focal UBUNTU_CODENAME=focal

ansible --version ansible [core 2.12.5] config file = None configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules'] ansible python module location = /opt/juimp/jdeployer/venv/lib/python3.10/site-packages/ansible ansible collection location = /root/.ansible/collections:/usr/share/ansible/collections executable location = /opt/juimp/jdeployer/venv/bin/ansible python version = 3.10.6 (main, May 29 2023, 11:10:38) [GCC 11.3.0] jinja version = 2.11.3 libyaml = False

Python 3.10.6 Kubespray version (commit) (git rev-parse --short HEAD): NA

Network plugin used: CNI

Full inventory with variables (ansible -i inventory/sample/inventory.ini all -m debug -a "var=hostvars[inventory_hostname]"):

Command used to invoke ansible:

ansible-playbook -i inventory/mycluster/hosts.yaml cluster.yml Output of ansible run:

Anything else do we need to know:

MrFreezeex commented 1 year ago

Hi! Thanks for the report, I am not sure we should really fix that considering that kubernetes 1.23 is end of life and that kubespray 1.22 is out though 🤔

prtkdave commented 1 year ago

I think we should get patch in this release as k8s 1.24 also used 1.8.6 while this will deploy wrong coredns version on k8s 1.24 as well.

https://github.com/coredns/deployment/blob/master/kubernetes/CoreDNS-k8s_version.md

VannTen commented 9 months ago

Looks like we now have the correct version in all supported releases branches, according to that link above. /close

k8s-ci-robot commented 9 months ago

@VannTen: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/kubespray/issues/10244#issuecomment-1904098566): >Looks like we now have the correct version in all supported releases branches, according to that link above. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.