Add support to use exisitng fips with terraform openstack

anders-elastisys commented 2 months ago

What type of PR is this? /kind feature

What this PR does / why we need it:

This PR adds Terraform Openstack support for specifying existing floating IPs on each machine listed in k8s_nodes and k8s_masters with a new optional variable reserved_floating_ip which is only used when the floating_ip variable is set to true. If reserved_floating_ip is not set and floating_ip is true, a new floating IP will be created same as before.

When reserved_floating_ip is set, that IP will get released and not deleted when deleting all Terraform resources.

Known limitations:

If you specify the same IP for reserved_floating_ip on multiple hosts, Terraform will not complain and only one machine gets assigned the IP in the end, as there is currently no check for whether or not the specific IP has already been assigned. The output will show the same IP several times as well.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add support to use existing fips with terraform OpenStack

k8s-ci-robot commented 2 months ago

Hi @anders-elastisys. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

yankay commented 2 months ago

/ok-to-test

yankay commented 2 months ago

Thanks @anders-elastisys /approve

tico88612 commented 1 month ago

/release-note-edit

Add support to use existing fips with terraform OpenStack

anders-elastisys commented 3 weeks ago

@yankay @cyclinder Hi, I believe a reviewer needs to add a lgtm label for this to be merged, could one of you help with this?

yankay commented 2 weeks ago

@yankay @cyclinder Hi, I believe a reviewer needs to add a lgtm label for this to be merged, could one of you help with this?

HI @tico88612 @VannTen Could you please help review it? Thanks!

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anders-elastisys, tico88612, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)~~ [yankay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubernetes-sigs / kubespray

Add support to use exisitng fips with terraform openstack #11558