search

kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.21k stars 6.5k forks source link

[2.25] Update to last patch versions (kubernetes, helm) #11599

Closed robertvolkmann closed 1 month ago

robertvolkmann commented 1 month ago

What type of PR is this? /kind api-change

What this PR does / why we need it: Add the latest patch version on some core components

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Default to kubernetes v1.29.9
Default to helm v3.14.4

/label tide/merge-method-merge

k8s-ci-robot commented 1 month ago

@robertvolkmann: The label(s) /label tide-merge-method-merge cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to [this](https://github.com/kubernetes-sigs/kubespray/pull/11599): >**What type of PR is this?** >/kind api-change > >**What this PR does / why we need it:** >Add the latest patch version on some core components > >**Special notes for your reviewer:** > >**Does this PR introduce a user-facing change?:** > >Default to kubernetes v1.29.9 >Default to containerd v1.7.22 >Default to cri-o v1.29.9 >Default to helm v3.14.4 >/label tide-merge-method-merge Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 month ago

Hi @robertvolkmann. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
VannTen commented 1 month ago

/ok-to-test /lgtm /approve

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robertvolkmann, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/release-2.25/OWNERS)~~ [VannTen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tico88612 commented 1 month ago

/retest-failed

VannTen commented 1 month ago

Maybe this needs #11584 backported ?

tico88612 commented 1 month ago

Maybe this needs #11584 backported ?

I think this is the problem. https://github.com/kubernetes-sigs/kubespray/pull/11533#issuecomment-2351387026

tico88612 commented 1 month ago

/remove-lgtm

tico88612 commented 1 month ago

If you need to upgrade cri-o, you must fix the cri-o binaries name first. You can refer to #10820 or #11533. If you don't know how to fix it, you can revert the cri-o version and open another issue, we'll fix it some other time.

robertvolkmann commented 1 month ago

I removed upgrading cri-o, because it is not needed on my side.

VannTen commented 1 month ago

/lgtm