search

kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.2k stars 6.48k forks source link

Always copy cert generation scripts to first etcd #11612

Closed VannTen closed 1 month ago

VannTen commented 1 month ago

What type of PR is this? /kind bug

What this PR does / why we need it: If we don't, existing installation would not pick up fixes to that script, such as #9974 (we we're just bitten by this while upgrading in 2.24.3, despite this being merged since 2.22)

Does this PR introduce a user-facing change?:

Always copy cert generation script to first etcd to pick up fixes on existing clusters
VannTen commented 1 month ago

/ok-to-test /cherry-pick release-2.26 /cherry-pick release-2.25 /cherry-pick release-2.24

k8s-infra-cherrypick-robot commented 1 month ago

@VannTen: once the present PR merges, I will cherry-pick it on top of release-2.26 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes-sigs/kubespray/pull/11612#issuecomment-2399752288): >/ok-to-test >/cherry-pick release-2.26 >/cherry-pick release-2.25 >/cherry-pick release-2.24 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
VannTen commented 1 month ago

/cherry-pick release-2.25

k8s-infra-cherrypick-robot commented 1 month ago

@VannTen: once the present PR merges, I will cherry-pick it on top of release-2.25 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes-sigs/kubespray/pull/11612#issuecomment-2399753633): >/cherry-pick release-2.25 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
VannTen commented 1 month ago

/cherry-pick release-2.24

k8s-infra-cherrypick-robot commented 1 month ago

@VannTen: once the present PR merges, I will cherry-pick it on top of release-2.24 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes-sigs/kubespray/pull/11612#issuecomment-2399754033): >/cherry-pick release-2.24 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)~~ [VannTen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-infra-cherrypick-robot commented 1 month ago

@VannTen: new pull request created: #11614

In response to [this](https://github.com/kubernetes-sigs/kubespray/pull/11612#issuecomment-2399754033): >/cherry-pick release-2.24 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 1 month ago

@VannTen: new pull request created: #11615

In response to [this](https://github.com/kubernetes-sigs/kubespray/pull/11612#issuecomment-2399752288): >/ok-to-test >/cherry-pick release-2.26 >/cherry-pick release-2.25 >/cherry-pick release-2.24 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 1 month ago

@VannTen: new pull request created: #11616

In response to [this](https://github.com/kubernetes-sigs/kubespray/pull/11612#issuecomment-2399753633): >/cherry-pick release-2.25 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.