search

kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.2k stars 6.48k forks source link

Cleanup: remove in-tree cloud provider support #11633

Closed tico88612 closed 2 weeks ago

tico88612 commented 1 month ago

What type of PR is this?

/kind cleanup /kind documentation

What this PR does / why we need it:

Kubernetes v1.31 remove in-tree cloud provider related code, we should remove related support.

Which issue(s) this PR fixes:

Fixes #10495

Special notes for your reviewer:

Waiting for #11378 get merge.

Does this PR introduce a user-facing change?:

[action required] no longer support in-tree cloud provider, please delete or write `external` to the `cloud_provider` variable.
k8s-ci-robot commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

VannTen commented 3 weeks ago

I don't actually think we need to wait for #11378 : since kubernetes v1.31 does not support in-tree provider, even if kubespray has support, it won't work. So let's proceed with the removal :+1:

tico88612 commented 2 weeks ago

/label tide/merge-method-merge /ok-to-test

VannTen commented 2 weeks ago

/approve Thanks for the work !

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)~~ [VannTen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment