kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.21k stars 6.49k forks source link

[2.26] Bump containerd 1.7.23 #11643

Closed robertvolkmann closed 1 month ago

robertvolkmann commented 1 month ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

Manual cherry-pick of #11642

Which issue(s) this PR fixes:

Fixes #11641

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Default to containerd v1.7.23
k8s-ci-robot commented 1 month ago

Hi @robertvolkmann. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tico88612 commented 1 month ago

Is it necessary to upgrade containerd in Kubespray version 2.26? I want to avoid the issue of package downgrades that occurred when upgrading from version 2.24.3 to 2.25.

tico88612 commented 1 month ago

/hold

robertvolkmann commented 1 month ago

Release v2.25.1 will contain containerd 1.7.22, so at least 1.7.22 should be part of a future v2.26.1.

VannTen commented 1 month ago

Is it necessary to upgrade containerd in Kubespray version 2.26? I want to avoid the issue of package downgrades that occurred when upgrading from version 2.24.3 to 2.25.

Given #11642 It does not seem to be a problem ? /approve /lgtm /ok-to-test (leaving the hold until we figure this out).

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robertvolkmann, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/release-2.26/OWNERS)~~ [VannTen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
VannTen commented 1 month ago

@tico88612 Any issue with merging this given the master had been updated as well ?

tico88612 commented 1 month ago

I think it's no problem here. /unhold