search

kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.2k stars 6.48k forks source link

Make cri-dockerd log level configurable #11646

Closed mirwan closed 1 month ago

mirwan commented 1 month ago

What type of PR is this? /kind feature

What this PR does / why we need it: cri-dockerd does log by default at the "info" level which may generate lots of log lines. This PR makes the log level configurable, leaving the current behaviour unchanged by setting the "info" as the default for the corresponding Ansible variable.

Which issue(s) this PR fixes: None that I know of

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Make cri-dockerd log level configurable
k8s-ci-robot commented 1 month ago

Hi @mirwan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tico88612 commented 1 month ago

/kind feature /release-note-edit

Make cri-dockerd log level configurable
mirwan commented 1 month ago

@tico88612 Thx for the review, I took into account your suggestions. Should I squash myself or is it done upon merge ?

yankay commented 1 month ago

/ok-to-test

tico88612 commented 1 month ago

@mirwan Yes, please squash this to one commit.

mirwan commented 1 month ago

@tico88612 That's it

VannTen commented 1 month ago

/approve

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mirwan, tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)~~ [VannTen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment