search

kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.2k stars 6.48k forks source link

fix kube-vip container securityContext #11647

Closed KubeKyrie closed 1 month ago

KubeKyrie commented 1 month ago

What type of PR is this? /kind bug

What this PR does / why we need it: kube-vip container need privileged: true to ensure net.ipv4.vs.conntrack when kube_vip_lb_fwdmethod is masquerade. See https://github.com/kube-vip/kube-vip/blob/v0.8.0/pkg/kubevip/config_generator.go#L526C1-L541C3

Which issue(s) this PR fixes:

Fixes https://github.com/kubernetes-sigs/kubespray/issues/11648

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix kube-vip container securityContext
k8s-ci-robot commented 1 month ago

Hi @KubeKyrie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
yankay commented 1 month ago

/ok-to-test

yankay commented 1 month ago

Thanks @KubeKyrie /approve

KubeKyrie commented 1 month ago

@cyclinder Could you help review it ? Thanks.

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KubeKyrie, tico88612, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)~~ [yankay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment