search

kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.2k stars 6.48k forks source link

Fix `debian11-custom-cni` failing test & upgrade `debian12-custom-cni-helm` chart version #11654

Closed tico88612 closed 1 month ago

tico88612 commented 1 month ago

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

11530 uses ci-full, but debian11-custom-cni has a failing test. I think the Cilium version is outdated. (Reason: kube_owner: root is required if CNI is cilium.)

Which issue(s) this PR fixes:

Related #11530

Special notes for your reviewer:

I will revert [WIP] commit after get approved.

Does this PR introduce a user-facing change?:

NONE
tico88612 commented 1 month ago

/ok-to-test

tico88612 commented 1 month ago

Passed.

image
VannTen commented 1 month ago

/approve

Thanks !

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)~~ [VannTen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tico88612 commented 1 month ago

Ready to merge and cherry-pick to other branches.

/cherry-pick release-2.26 /cherry-pick release-2.25

k8s-infra-cherrypick-robot commented 1 month ago

@tico88612: once the present PR merges, I will cherry-pick it on top of release-2.26 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes-sigs/kubespray/pull/11654#issuecomment-2429427513): >Ready to merge and cherry-pick to other branches. > >/cherry-pick release-2.26 >/cherry-pick release-2.25 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
VannTen commented 1 month ago

/lgtm

k8s-infra-cherrypick-robot commented 1 month ago

@tico88612: new pull request created: #11658

In response to [this](https://github.com/kubernetes-sigs/kubespray/pull/11654#issuecomment-2429427513): >Ready to merge and cherry-pick to other branches. > >/cherry-pick release-2.26 >/cherry-pick release-2.25 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 1 month ago

@tico88612: new pull request created: #11659

In response to [this](https://github.com/kubernetes-sigs/kubespray/pull/11654#issuecomment-2429427513): >Ready to merge and cherry-pick to other branches. > >/cherry-pick release-2.26 >/cherry-pick release-2.25 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.