Closed 0x4c6565 closed 2 weeks ago
Hi @0x4c6565. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
Thanks @0x4c6565 /approve
@cyclinder would you please help to review it .
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: 0x4c6565, yankay
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
/cc @yankay Could you please approval this?
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds an extra variable
nodelocaldns_additional_configs
to allow additional config to be added to the node-local DNS CoreDNS config, just as can be done with normal CoreDNS config with variablecoredns_additional_configs
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Could we simply reuse the existing variable
coredns_additional_configs
here instead of adding a new variable?Does this PR introduce a user-facing change?: