kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.21k stars 6.49k forks source link

Adds `nodelocaldns_additional_configs` to facilitate additional CoreDNS config options #11657

Closed 0x4c6565 closed 2 weeks ago

0x4c6565 commented 1 month ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds an extra variable nodelocaldns_additional_configs to allow additional config to be added to the node-local DNS CoreDNS config, just as can be done with normal CoreDNS config with variable coredns_additional_configs

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Could we simply reuse the existing variable coredns_additional_configs here instead of adding a new variable?

Does this PR introduce a user-facing change?:

Adds `nodelocaldns_additional_configs` variable
k8s-ci-robot commented 1 month ago

Hi @0x4c6565. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
yankay commented 1 month ago

/ok-to-test

yankay commented 1 month ago

Thanks @0x4c6565 /approve

@cyclinder would you please help to review it .

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0x4c6565, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)~~ [yankay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cyclinder commented 2 weeks ago

/lgtm

/cc @yankay Could you please approval this?