search

kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.2k stars 6.48k forks source link

coredns: add includeUnschedulableNodes for dns-autoscaler #11680

Open liupeng0518 opened 3 weeks ago

liupeng0518 commented 3 weeks ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake

/kind feature

What this PR does / why we need it: Add includeUnschedulableNodes for dns-autoscaler.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liupeng0518

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)~~ [liupeng0518] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MrFreezeex commented 2 weeks ago

I didn't fuly checked the logs but it look like dns-autoscaler is failing in the CI with this change:

        "kube-system   dns-autoscaler-84ddb845b4-c74cw            0/1     CrashLoopBackOff   9 (16s ago)     7m19s   10.233.87.130   instance-1   <none>           <none>",