search

kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.2k stars 6.49k forks source link

Correct the PKG dependency list for openEuler-2203 #11685

Closed leeonfu closed 2 weeks ago

leeonfu commented 2 weeks ago

What type of PR is this?

/kind bug

What this PR does / why we need it: Provide a support for openEuler-2202

Which issue(s) this PR fixes:

Fixes #11660

Special notes for your reviewer: @yankay

Does this PR introduce a user-facing change?:

NONE
k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leeonfu Once this PR has been reviewed and has the lgtm label, please assign liupeng0518 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 2 weeks ago

Hi @leeonfu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tico88612 commented 2 weeks ago

@leeonfu Thanks for your PR, but the PR does not allow any merge commit. Could you remove it?

leeonfu commented 2 weeks ago

@leeonfu Thanks for your PR, but the PR does not allow any merge commit. Could you remove it?

Hi @tico88612 , Already removed.

yankay commented 2 weeks ago

/ok-to-test

leeonfu commented 2 weeks ago

/retest

VannTen commented 2 weeks ago

I'm not sure where you got os_families btw ? Ansible set ansible_os_family but I don't think we use os_families

leeonfu commented 2 weeks ago

I'm not sure where you got os_families btw ? Ansible set ansible_os_family but I don't think we use os_families

os_families just to re-write the setup ansible env vars. the os_families not a fact.

VannTen commented 2 weeks ago

os_families just to re-write the setup ansible env vars. the os_families not a fact.

Didn't parse that. What do you mean ?

k8s-ci-robot commented 2 weeks ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.