kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.2k stars 6.49k forks source link

Add a new crio_root variable in order to store CRI-O data on somethin… #11692

Closed toliger closed 2 weeks ago

toliger commented 2 weeks ago

What type of PR is this? /kind feature

What this PR does / why we need it: This change give the opportunity to change the CRI-O storage location.

Which issue(s) this PR fixes: https://github.com/kubernetes-sigs/kubespray/issues/11686

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add a new CRI-O `crio_root` variable
k8s-ci-robot commented 2 weeks ago

Hi @toliger. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tico88612 commented 2 weeks ago

/ok-to-test

yankay commented 2 weeks ago

Thanks @toliger /approve

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tico88612, toliger, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)~~ [yankay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment