kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.2k stars 6.49k forks source link

preinstall: fix checking that excluded host are cached #11693

Closed VannTen closed 2 weeks ago

VannTen commented 2 weeks ago

What type of PR is this? /kind bug

What this PR does / why we need it: See commits

Which issue(s) this PR fixes:

Fixes #11690

Special notes for your reviewer: Fix the implementation of #11598 @tico88612 can you test this ? My vagrant install is borked at the moment. I tested the assert on a live cluster but only on it's own, not inside kubespray)

Does this PR introduce a user-facing change?:

Fix the check for cached data when using --limit
VannTen commented 2 weeks ago

/ok-to-test

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)~~ [VannTen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment