Closed VannTen closed 4 days ago
/ok-to-test
/cherrypick release-2.26 /cherrypick release-2.25 /cherrypick release-2.24
@VannTen: once the present PR merges, I will cherry-pick it on top of release-2.24
, release-2.25
, release-2.26
in new PRs and assign them to you.
/cc @tico88612
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: tico88612, VannTen
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@VannTen: new pull request created: #11721
@VannTen: new pull request created: #11722
@VannTen: new pull request created: #11723
What type of PR is this? /kind bug
What this PR does / why we need it: When using
This is rendered in the dns configmap as ($ for end-of-line)
... prefer_udp $ ...
Note the trailing space. This triggers https://github.com/kubernetes/kubernetes/issues/36222, which makes the configmap hardly readable when editing them manually or simply putting them in a yaml file for inspection.
Trim the concatenation of option + value to get rid of any trailing space. Example of kubectl edit on such a configmap:
Special notes for your reviewer: This is pretty minor, but pretty annoying !
Does this PR introduce a user-facing change?: