Open Xartos opened 1 week ago
Hi @Xartos. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Xartos Once this PR has been reviewed and has the lgtm label, please assign liupeng0518 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/ok-to-test
Not much comment (not my area of expertise), but I suggest you split your two last commits into a separate PR, since they are just linting fixes, that will make it easier to review (unless they fixes previous commits, in which case you should squash them into the approriate commits).
(Probably apply for other stuff as well, for examples, the schema removal in docs, agree it's redundant but it's probaly simpler to pull that into a separate change)
…e IPs<!-- Thanks for sending a pull request! Here are some tips for you:
What type of PR is this?
What this PR does / why we need it:
To increase the attack surface of clusters in upcloud we want to reduce the publicly facing IPs. Therefore this PR adds support for setting up a cluster without public IPs on the nodes. This was impossible previously.
Which issue(s) this PR fixes:
Fixes #N/A
Special notes for your reviewer:
This PR depends on this PR, so I'll wait with merging this one until that PR is merged.
This change will change the output variable names.
Does this PR introduce a user-facing change?: