kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.2k stars 6.49k forks source link

remove nameless extraArgs entry #11703

Closed agravgaard closed 1 week ago

agravgaard commented 1 week ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

Remove empty entry in extraArgs for kubeadm config v1beta4, as it causes upload-certs to fail with the following error:

etcd.local.extraArgs: Invalid value: "index 5": argument has no name

Also, the same PR, which introduced the above bug renamed the kubeadm-client.conf template, but left behind a reference to the old name, which I fixed as well.

Which issue(s) this PR fixes:

I haven't opened an issue for this - it was easier to just fix it. Fixes #

Special notes for your reviewer:

The bug was introduced with the file recently: https://github.com/kubernetes-sigs/kubespray/pull/11674

Does this PR introduce a user-facing change?:

remove invalid extraArgs entry and update template file reference
linux-foundation-easycla[bot] commented 1 week ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 week ago

Welcome @agravgaard!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 week ago

Hi @agravgaard. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
yankay commented 1 week ago

/ok-to-test

VannTen commented 1 week ago

/retest-failed

tico88612 commented 1 week ago

/retest

tico88612 commented 1 week ago

/retest-failed

VannTen commented 1 week ago

/approve

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agravgaard, tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)~~ [VannTen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
VannTen commented 1 week ago

@tico88612 Looks like this wasn't caught by CI because we have a blanket ignore-preflight-errors=all in the kubeadm command (there is another strict decoding error). It appears to make kubeadm to fail in some places but not all for some reason.

I'm gonna try to change that all into a smaller set