search

kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.2k stars 6.49k forks source link

Remove deprecated key from kubeadmconfig/v1beta4 #11709

Closed VannTen closed 1 week ago

VannTen commented 1 week ago

What type of PR is this? /kind bug

What this PR does / why we need it: timeoutForControlPlane has been removed from v1beta4, instead remplaced by https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta4/#kubeadm-k8s-io-v1beta4-Timeouts We have currently failing tests for this, but might be overshadowed by the --ignore-preflight-errors=all

The default for the new value are close enough that there is no need to override them, IMO

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix format of kubeadm-config v1beta4
VannTen commented 1 week ago

/ok-to-test

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)~~ [VannTen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment