search

kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.2k stars 6.49k forks source link

[release-2.24] Fix pretty-printing of coredns and nodelocaldns configmaps #11722

Closed k8s-infra-cherrypick-robot closed 3 days ago

k8s-infra-cherrypick-robot commented 4 days ago

This is an automated cherry-pick of #11694

/assign VannTen

Fix pretty-printing (in kubectl) of nodelocaldns and coredns configmap when using `dns_upstream_forward_extra_opts` with an empty value option.
VannTen commented 4 days ago

/lgtm /approve

VannTen commented 4 days ago

/assign @mzaian

k8s-ci-robot commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, mzaian, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/release-2.24/OWNERS)~~ [mzaian] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
VannTen commented 3 days ago

Hum

Shouldn't this merge ?