search

kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.2k stars 6.49k forks source link

Fix: Prioritize 'access_ip' over 'ip' in etcd configuration for better flexibility in isolated cluster #11725

Open M-JavadHeydarpour opened 3 days ago

M-JavadHeydarpour commented 3 days ago

What type of PR is this? /kind bug /kind feature

What this PR does / why we need it:

This pull request refactors the etcd configuration to prioritize access_ip over ip in several places in the Kubespray defaults. This change ensures that etcd nodes use the correct access_ip for communication between nodes and for accessing services like events and metrics. It simplifies handling in environments where nodes have multiple IP addresses (e.g., internal and external).

Which issue(s) this PR fixes: Fixes #10445 Fixes #11560

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Refactor etcd configuration to use `access_ip` over `ip` for more reliable etcd cluster communication and service access.
k8s-ci-robot commented 3 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: M-JavadHeydarpour Once this PR has been reviewed and has the lgtm label, please assign floryut for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 3 days ago

Hi @M-JavadHeydarpour. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
yankay commented 3 days ago

/ok-to-test