search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
331 stars 106 forks source link

Revert "kubetest2 gke deployer supports retries with different subnet… #144

Closed amwat closed 3 years ago

amwat commented 3 years ago

… ranges to avoid conflicts."

This reverts commit 74cf642d943febf598a8e4085dff47555eb605ff.

ref: https://github.com/kubernetes-sigs/kubetest2/commit/66afb490ec30c4f12f621a63f1c6cad42247a35f#r52588671

/cc @chizhg @joshua-bone @BenTheElder

k8s-ci-robot commented 3 years ago

@amwat: GitHub didn't allow me to request PR reviews from the following users: joshua-bone.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/kubetest2/pull/144): >… ranges to avoid conflicts." > >This reverts commit 74cf642d943febf598a8e4085dff47555eb605ff. > >ref: https://github.com/kubernetes-sigs/kubetest2/commit/66afb490ec30c4f12f621a63f1c6cad42247a35f#r52588671 > >/cc @chizhg @joshua-bone @BenTheElder Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [amwat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
BenTheElder commented 3 years ago

/lgtm