search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
331 stars 106 forks source link

Fix to kubetest2 gke deployer supports retries with different subnet ranges to avoid conflicts #146

Closed chizhg closed 3 years ago

chizhg commented 3 years ago
  1. Fix to the issue in https://github.com/kubernetes-sigs/kubetest2/commit/66afb490ec30c4f12f621a63f1c6cad42247a35f#r52588671
  2. Also fix one issue in parsing the server config - yaml unmarshal has some issues with parsing the nested structs, switching to json instead.

I have tested it in our existing CI flows and everything works fine.

chizhg commented 3 years ago

/cc @amwat @BenTheElder

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, chizhg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [amwat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment