search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
331 stars 106 forks source link

Add windows/amd64 in target platform #155

Closed anfernee closed 3 years ago

anfernee commented 3 years ago

The build only builds linux/amd64 now.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anfernee To complete the pull request process, please assign bentheelder after the PR has been reviewed. You can assign the PR to them by writing /assign @bentheelder in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
amwat commented 3 years ago

/hold

I think this should be set in the config instead of in code

anfernee commented 3 years ago

I think for GKE, it's always built this way with support of both platforms. if that's the case, we should probably do the same thing here.

amwat commented 3 years ago

From kubetest2 perspective we still want the ability to specify linux only building for faster builds. Hardcoding the TARGET_PLATFORMS means we lose that. Currently, we can pass whatever TARGET_PLATFORMS we want through the config file, we can add windows there.

anfernee commented 3 years ago

Which config file are you referring to? I saw some BuildOptions fields. Do you think it's common build option or gke specific build option?

amwat commented 3 years ago

the BuildScript flag takes in a config file with the gke_make build options including TARGET_PLATFORMS.

anfernee commented 3 years ago

Per @amwat this change is not needed.