Closed Namanl2001 closed 2 years ago
Hi @Namanl2001. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@amwat should we also initialize BoskosHeartbeatIntervalSeconds
in node tester like so: https://github.com/kubernetes-sigs/kubetest2/blob/67b31b5cf8c6c559f6d5e6221164210912a6b65d/kubetest2-gce/deployer/deployer.go#L126
@amwat should we also initialize
BoskosHeartbeatIntervalSeconds
in node tester like so:
Yes, good catch!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: amwat, Namanl2001
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Signed-off-by: Namanl2001 namanlakhwani@gmail.com
ref: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/92316/pull-kubernetes-node-e2e-kubetest2/1443216968134955008#1:build-log.txt%3A7