kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
326 stars 105 forks source link

gke: Remove hardcoded default machine types #174

Closed bobbypage closed 2 years ago

bobbypage commented 2 years ago

Remove hardcoded machine types and instead rely on the server side defaults. Only pass machineType flag if machine type is explicitly provided.

k8s-ci-robot commented 2 years ago

Hi @bobbypage. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bobbypage commented 2 years ago

Followup on @SergeyKanzhelev comment here - https://github.com/kubernetes-sigs/kubetest2/pull/171#pullrequestreview-797263709

bobbypage commented 2 years ago

/assign @amwat

chizhg commented 2 years ago

/ok-to-test /lgtm

amwat commented 2 years ago

/approve

Thank you!

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, bobbypage, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [amwat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment