Closed krzykwas closed 2 years ago
Welcome @krzykwas!
It looks like this is your first PR to kubernetes-sigs/kubetest2 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/kubetest2 has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @krzykwas. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/cc @BenTheElder
/retest
/retest
/assign @amwat /assign @BenTheElder
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: BenTheElder, krzykwas
The full list of commands accepted by this bot can be found here.
The pull request process is described here
The NODE_SCOPES and KUBE_GCE_NODE_SERVICE_ACCOUNT are necessary to be able to create a cluster whose nodes use a specific service account as their identity. Using a specific service account, the workloads running on the nodes can authenticate with the Compute API without using service account keys (and exporting service account keys is discouraged as it is unsafe).
I tested manually that it is possible to authenticate the workloads on a cluster created by cluster/kube-up.sh if the NODE_SCOPES and KUBE_GCE_NODE_SERVICE_ACCOUNT variables are set. Now I'd like to do a similar thing with a Google-internal Prow instance and I'm not sure if I could easily test this PR on this internal instance (though this PR is a small one and it seems to me it should work fine). Please advise as I don't have much experience developing against kubetest2.