search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
326 stars 105 forks source link

[Bug fix] Boskos release should set the resource state to dirty #180

Closed chizhg closed 2 years ago

chizhg commented 2 years ago

To use Boskos as the GCP project rental, when releasing the project, it should reset its state to dirty instead of free, this'll allow GCP Janitor to clean up all resources in the project and reset it to free, so that the project can be returned to the project rental in a clean state.

/cc @MushuEE

chizhg commented 2 years ago

/uncc @MushuEE /cc @spiffxp

chizhg commented 2 years ago

/close

k8s-ci-robot commented 2 years ago

@chizhg: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/kubetest2/pull/180#issuecomment-1027395687): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chizhg commented 2 years ago

/reopen

k8s-ci-robot commented 2 years ago

@chizhg: Reopened this PR.

In response to [this](https://github.com/kubernetes-sigs/kubetest2/pull/180#issuecomment-1041003234): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chizhg commented 2 years ago

/cc @BenTheElder Hi Ben, Aaron, could you help review this small PR? It's only a one-line change. Thanks!

BenTheElder commented 2 years ago

Aaron is on long-term leave ATM.

I'm concerned that we've been running this and apparently not noticing 🤨 /lgtm /hold

chizhg commented 2 years ago

Aaron is on long-term leave ATM.

I'm concerned that we've been running this and apparently not noticing 🤨 /lgtm /hold

Previously --down did not release the Boskos projects and I made the change in https://github.com/kubernetes-sigs/kubetest2/pull/177. Maybe GKE/Kubernetes was not using the latest kubetest2 version / not using Boskos?

chizhg commented 2 years ago

@BenTheElder could you take a second look on this? If it looks good may I get an approval?

BenTheElder commented 2 years ago

/hold cancel

chizhg commented 2 years ago

It's actually missing /approve

BenTheElder commented 2 years ago

/approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, chizhg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [BenTheElder] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment