search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
331 stars 106 forks source link

Allow rundir to be set with SetRunDir #182

Closed nckturner closed 2 years ago

nckturner commented 2 years ago

Kops wraps the ginkgo tester with its own tester, but doesn't has its own Execute() method. This will allow the kops tester to use KUBETEST2_RUN_DIR as the runDir without much refactoring.

See https://github.com/kubernetes/kops/pull/13217

nckturner commented 2 years ago

/assign @spiffxp @BenTheElder

nckturner commented 2 years ago

Is this reasonable?

BenTheElder commented 2 years ago

sorry, Aaron is on leave and Amit moved on so it's just me in this repo right now, this seems reasonable.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [BenTheElder] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment