kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
331 stars 106 forks source link

--use-built-binaries for tests doesn't work with kind deployer #184

Open andrewsykim opened 2 years ago

andrewsykim commented 2 years ago

Setting the --use-built-binaries flag for running tests doesn't seem to be working when using the kind deployer because the kind node image builder doesn't bundle the e2e.test binary.

I wasn't sure if this was expected behavior but being able to run a single command to build a kind node image, start the cluster, and then run tests would be useful:

kubetest2 kind --build --test=ginkgo --up --kube-root=$(pwd) --config=./kind-config.yaml -- --focus-regex=<regex> --use-built-binaries
BenTheElder commented 2 years ago

That seems like a bug, the builder should build the e2e binary, similar to https://github.com/kubernetes-sigs/kind/blob/main/hack/ci/e2e-k8s.sh

/help

k8s-ci-robot commented 2 years ago

@BenTheElder: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/kubetest2/issues/184): >That seems like a bug, the builder should build the e2e binary, similar to https://github.com/kubernetes-sigs/kind/blob/main/hack/ci/e2e-k8s.sh > >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

vaibhav2107 commented 2 years ago

/remove-lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

aramase commented 1 year ago

Hitting this issue in our job too: https://prow.k8s.io/log?container=test&id=1625285724066549760&job=pull-kubernetes-e2e-kind-kms. This is the command we're running: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-auth/sig-auth-encryption-at-rest.yaml#L41-L52

aramase commented 1 year ago

/remove-lifecycle stale