Closed richackard closed 2 years ago
Hi @richackard. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Changed the build marker staging logic for the GKE Deployer so that it only gets staged to GCS after the build / test is completed successfully.
I'm not sure this is something we should be doing, it seems like an abuse of the build marker.
What happens if I only run --build?
If this is meant to be a marker of test passing, why not upload a distinct marker for that?
Let's make the original marker serve its own purpose. Will add a flag to control whether we should also stage a "green version" of the build marker.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: BenTheElder, richackard
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Changed the build marker staging logic for the GKE Deployer so that it only gets staged to GCS after the build / test is completed successfully.