search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
331 stars 106 forks source link

Implement minikube deployer #190

Closed tallclair closed 1 year ago

tallclair commented 2 years ago

Would be great to have a minikube deployer, as an alternative to kind for local development.

/help

k8s-ci-robot commented 2 years ago

@tallclair: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/kubetest2/issues/190): >Would be great to have a minikube deployer, as an alternative to kind for local development. > >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
BenTheElder commented 2 years ago

FWIW: We don't necessarily intend to have all deployers in this repo, kubetest2 is usable as a library, we have a few exec based deployers here as references, but for example kops implements one in their repo, so they can use kops as a library (and not pollute the dependencies in this repo).

https://kops.sigs.k8s.io/contributing/testing/#kubernetes-e2e-testing https://pkg.go.dev/k8s.io/kops/tests/e2e/kubetest2-kops

We had a lot of headache with kubetest as a single binary and deployer dependencies in the past, so kubetest2 is hopefully very easy to import, shim, and support in external projects.

There's an argument to be made for moving out the existing deployers, though we probably want to keep at least one of the no-dependency deployers just as a reference implementation.

We also have extremely little bandwidth to review and approve changes in this repo, currently I am the only active approver 🙃 , so implementing additional deployers externally keeps down my already over-subscribed review load.

tallclair commented 2 years ago

That makes sense. In that case, it might be helpful to keep an index of other deployer implementations here.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/kubetest2/issues/190#issuecomment-1281385533): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.