search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
326 stars 105 forks source link

Implement AKS deployer #193

Closed helayoty closed 1 year ago

helayoty commented 2 years ago

Would be great to have an AKS deployer available in kubetest2. That will help us integrate with e2e-framework as we were discussing here

/help

k8s-ci-robot commented 2 years ago

@helayoty: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/kubetest2/issues/193): >Would be great to have an AKS deployer available in `kubetest2`. That will help us integrate with [e2e-framework](https://github.com/kubernetes-sigs/e2e-framework) as we were discussing [here](https://github.com/kubernetes-sigs/e2e-framework/issues/131) > >/help > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
BenTheElder commented 2 years ago

FWIW: see discussion in https://github.com/kubernetes-sigs/kubetest2/issues/190#issuecomment-1132299937

TLDR: The deployers we have now are meant to be relatively simple, zero dependency (only exec) examples.

kubetest2 is expressly designed to enable implementing more deployers out of tree with tighter integration (e.g. using the EKS or AKS or kops libraries) without the dependency and globals hell we had in kubetest (by keeping them in seperate binaries + modules with seperate dep trees), and with independent maintainers. etc.

kubetest2 operates on a binary plugin model, so external deployers are pretty much on the same level as anything in-tree. we just need something in tree for developing the project, so we ported some of the most used deployers from the old kubetest

we should probably improve the docs to more clearly emphasize how the project is meant to be extensible out of tree.

also, at the moment, I am the sole active maintainer, and my focus doesn't lie here, so i'm over extended with the currently available features 😞

kops is here: https://pkg.go.dev/k8s.io/kops/tests/e2e/kubetest2-kops https://kops.sigs.k8s.io/contributing/testing/#kubernetes-e2e-testing

spiffxp commented 1 year ago

/close Looks like https://github.com/kubernetes-sigs/cloud-provider-azure/pull/2163 has implemented kubetest2-aks

k8s-ci-robot commented 1 year ago

@spiffxp: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/kubetest2/issues/193#issuecomment-1227741395): >/close >Looks like https://github.com/kubernetes-sigs/cloud-provider-azure/pull/2163 has implemented `kubetest2-aks` Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
BenTheElder commented 1 year ago

we should consider pointing to some of these projects from the README