search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
326 stars 105 forks source link

Switch to golang native error wrapping #198

Closed saschagrunert closed 1 year ago

saschagrunert commented 2 years ago

We now use the native error wrapping support since github.com/pkg/errors is read-only.

BenTheElder commented 1 year ago

this does mean a loss of stack traces though, and pkg/errors doesn't have much code in it.

given how little we appear to be using it to begin with though ... /lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [BenTheElder] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment