search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
326 stars 105 forks source link

Update ginkgo flags #200

Closed leonardpahlke closed 2 years ago

leonardpahlke commented 2 years ago

Signed-off-by: leonardpahlke leonard.pahlke@googlemail.com

Update ginkgo flags to work with ginkgo 2.0 (see migration guide)

/cc @aojea @chendave

see also this testgrid issue that should be fixed https://github.com/kubernetes/kubernetes/issues/111072

/kind cleanup /kind deprecation

k8s-ci-robot commented 2 years ago

@leonardpahlke: GitHub didn't allow me to request PR reviews from the following users: chendave.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/kubetest2/pull/200): >Signed-off-by: leonardpahlke > >Update ginkgo flags to work with ginkgo 2.0 (see [migration guide](https://onsi.github.io/ginkgo/MIGRATING_TO_V2)) > >/cc @aojea @chendave > >see also this testgrid issue that should be fixed https://github.com/kubernetes/kubernetes/issues/111072 > >/kind cleanup >/kind deprecation > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aojea commented 2 years ago

/lgtm /assign @MushuEE

chendave commented 2 years ago

LGTM, thanks for the fix.

MushuEE commented 2 years ago

/lgtm /approval

MushuEE commented 2 years ago

/approved

MushuEE commented 2 years ago

/approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leonardpahlke, MushuEE

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [MushuEE] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rifelpet commented 1 year ago

FYI this causes problems when testing older k8s versions, see https://github.com/kubernetes-sigs/kubetest2/issues/204