search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
326 stars 105 forks source link

revert naming of FlakeAttempts #201

Closed GanjMonk closed 1 year ago

GanjMonk commented 2 years ago

premature change of naming, ginkgo v2 is not running when kubetest2 installed from scratch

linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 2 years ago

Welcome @GanjMonk!

It looks like this is your first PR to kubernetes-sigs/kubetest2 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubetest2 has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 2 years ago

Hi @GanjMonk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GanjMonk Once this PR has been reviewed and has the lgtm label, please assign mushuee for approval by writing /assign @mushuee in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
BenTheElder commented 1 year ago

I think we can do better for this, like detecting the ginkgo binary version or something. We do need to work with Kubernetes development at HEAD as well as past release branches.

cc @chendave

chendave commented 1 year ago

I think we can do better for this, like detecting the ginkgo binary version or something.

+1, maybe a change like this one https://github.com/kubernetes/test-infra/pull/26250

We do need to work with Kubernetes development at HEAD as well as past release branches.

+1 too, the support for flakeAttempts will eventually gone with ginkgo v2, I am afraid this will break the test again at some time in the future.

aojea commented 1 year ago

I have a better fix for this

BenTheElder commented 1 year ago

thanks for the PR -- please check if antonio's solution works for you https://github.com/kubernetes-sigs/kubetest2/pull/206,

k8s-ci-robot commented 1 year ago

@GanjMonk: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
spiffxp commented 1 year ago

/close Closing in favor of https://github.com/kubernetes-sigs/kubetest2/pull/206

k8s-ci-robot commented 1 year ago

@spiffxp: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/kubetest2/pull/201#issuecomment-1227765509): >/close >Closing in favor of https://github.com/kubernetes-sigs/kubetest2/pull/206 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.