search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
326 stars 105 forks source link

ginkgo v2 backwards compatible #206

Closed aojea closed 1 year ago

aojea commented 1 year ago

some ginkgo flags and behaviors are not backwards compatible, detect the major version to configure accordingly

Fixes #204

aojea commented 1 year ago

/assign @BenTheElder @chendave @MushuEE

I couldn't test it, is there a way to verify it works correctly?

k8s-ci-robot commented 1 year ago

@aojea: GitHub didn't allow me to assign the following users: chendave.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/kubetest2/pull/206#issuecomment-1200444054): >/assign @BenTheElder @chendave @MushuEE > >I couldn't test it, is there a way to verify it works correctly? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [BenTheElder] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment