search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
331 stars 106 forks source link

synchronize systemout #211

Closed BenTheElder closed 2 years ago

BenTheElder commented 2 years ago

fixes #210

NOTE: we don't bother synchronizing .String() because the process is errored and dead when we're reading it.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [BenTheElder] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
liggitt commented 2 years ago

/lgtm

xmcqueen commented 2 years ago

nice /lgtm

k8s-ci-robot commented 2 years ago

@xmcqueen: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/kubetest2/pull/211#issuecomment-1212329201): >nice >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ameukam commented 2 years ago

/lgtm

MushuEE commented 2 years ago

/approve