search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
326 stars 105 forks source link

update .go-version to 1.17.13 and go mod tidy #214

Closed spiffxp closed 1 year ago

spiffxp commented 1 year ago

Related:

go install sigs.k8s.io/kubetest2/...@latest was failing for go 1.17, somehow deciding to pull in dependencies that require go >= 1.18 despite https://github.com/kubernetes-sigs/kubetest2/pull/207

go build ./... was refusing to build for go >= 1.17, saying that go mod tidy needed to be run first (see https://go.dev/ref/mod#go-mod-file-go for why)

The Makefile used as the entrypoint for all of this project's CI jobs uses the go version specified in .go-version so we were missing this failure mode. Added a go-version target which gets run as part of make verify to hopefully catch this in the future

MushuEE commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MushuEE, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [MushuEE] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment