search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
325 stars 104 forks source link

dump cluster logs to artifacts dir instead of run dir #224

Closed spiffxp closed 1 year ago

spiffxp commented 1 year ago

Fallout from https://github.com/kubernetes-sigs/kubetest2/pull/183

Logs used to be uploaded because rundir was inside of ARTIFACTS, e.g. https://gcsweb.k8s.io/gcs/kubernetes-jenkins/logs/ci-kubernetes-gce-conformance-latest-kubetest2/1540532050887446528/artifacts/eb7a368d-f433-11ec-9e31-9224b4edca5e/

spiffxp commented 1 year ago

/test gce-build-up-down

spiffxp commented 1 year ago

I'm wondering if https://github.com/kubernetes/cloud-provider-gcp/pull/369/commits/84826703ed30c052de50eca706cb291ea30e4cc5 broke the gce-build-up-down job

spiffxp commented 1 year ago

Tried manually reverting that commit in a docker run of kubekins, same error

Now my guess is the gce-build-up-down job needs to move to bazel 5.3.0 as was done for the cloud-provider-gcp jobs (e.g. https://github.com/kubernetes/test-infra/pull/27335) though I'm not sure what required it

MushuEE commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MushuEE, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [MushuEE,spiffxp] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment