kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
325 stars 104 forks source link

Define the parameters needed to build arm64 binaries #229

Closed chendave closed 1 year ago

chendave commented 1 year ago

pls see: https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-node-arm64-ubuntu-serial/1666321790525247488/build-log.txt

The job ci-kubernetes-node-arm64-ubuntu-serial is failing because the binaries, such as "ginkgo" are copied from the wrong location and they were build for linux/amd64 instead.

/cc @ike-ma /cc @dims /cc @pacoxu

ref: https://github.com/kubernetes/kubernetes/pull/118567 https://github.com/kubernetes/test-infra/pull/29727

k8s-ci-robot commented 1 year ago

@chendave: GitHub didn't allow me to request PR reviews from the following users: ike-ma.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/kubetest2/pull/229): >pls see: https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-node-arm64-ubuntu-serial/1666321790525247488/build-log.txt > >The job ci-kubernetes-node-arm64-ubuntu-serial is failing because the binaries, such as "ginkgo" are copied from the wrong location and they were build for linux/amd64 instead. > >/cc @ike-ma >/cc @dims >/cc @pacoxu > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

Welcome @chendave!

It looks like this is your first PR to kubernetes-sigs/kubetest2 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubetest2 has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 year ago

Hi @chendave. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pacoxu commented 1 year ago

/ok-to-test

pacoxu commented 1 year ago

/cc @mushuee

pacoxu commented 1 year ago

Link to https://github.com/kubernetes/kubernetes/blob/9f7e43915766607b7ff281b91caf17cca7123576/test/e2e_node/builder/build.go#L32-L34 for reviewing.

dims commented 1 year ago

/approve

chendave commented 1 year ago

/assign @spiffxp @MushuEE

for review and approval, thanks!

MushuEE commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chendave, dims, MushuEE

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [MushuEE] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment