search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
331 stars 106 forks source link

Add myself and dims as reviewers & sig-testing leadership as approvers #231

Closed upodroid closed 1 year ago

upodroid commented 1 year ago

/cc @dims

dims commented 1 year ago

yes please!

upodroid commented 1 year ago

/cc @michelle192837

upodroid commented 1 year ago

@BenTheElder moved himself to emeritus recently so I left him out

michelle192837 commented 1 year ago

Ah sorry, OWNERS in test-infra aren't quite up to date. I'd use https://github.com/kubernetes/community/blob/master/sig-testing/README.md#leadership as a reference instead.

upodroid commented 1 year ago

Fixed

michelle192837 commented 1 year ago

Thanks! (Sorry to nitpick again but I think just having the chairs atm instead of all the leads might be better; we can stay on temporarily while we help find other owners, but unless any particular leads want to add themselves I don't think they need to also find owners).

Otherwise looks good to me, thanks!

MushuEE commented 1 year ago

/lgtm /approve

upodroid commented 1 year ago

/hold cancel

I limited approvers to chairs only for now.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837, MushuEE, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [MushuEE] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment