search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
325 stars 105 forks source link

Add an env for `timeout` for ginkgo tests #233

Closed chendave closed 11 months ago

chendave commented 11 months ago

By default, it only allows the ginkgo test to run 45 minutes, then the test will abort.

But it's not enough to run slow tests, in order to run slow test, we should provide a way to define the timeout if the CI job is run by kubetest2

You can find this in the log where slow tests are executed.

[sig-node] Restart [Serial] [Slow] [Disruptive] Container Runtime Network should recover from ip leak ... Interrupted by User First interrupt received; Ginkgo will run any cleanup and reporting nodes but will skip all remaining specs. Interrupt again to skip cleanup. /bin/bash: line 1: 2134 Killed timeout -k 30s 2700.000000s ./ginkgo ...

chendave commented 11 months ago

/cc @dims who knows the context of this.

dims commented 11 months ago

/approve /lgtm

chendave commented 11 months ago

Looking for something to approve this,

/assign @michelle192837 @MushuEE

Can you pls help to review? thanks!

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chendave, dims, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [michelle192837] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment