kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
331 stars 106 forks source link

add support for specifying env parameters for kubetest2-gce deployer #240

Closed upodroid closed 1 year ago

upodroid commented 1 year ago

/cc @dims @tzneal

~In theory, all we need to do to run arm e2e tests on GCP is to compile arm binaries, create VMs with arm machine types and use the arm images~

k/k cluster scripts are too buggy right now to support arm64 building, but the feature is required for passing env variables to the kube-*.sh scripts.

I'll create a separate job to run the legacy-mode tests

ruquanzhao commented 1 year ago

It looks like the CI failed because some hardcode in k/k shell scripts. I raise a PR about env KUBE_BUILD_PLATFROMS in https://github.com/kubernetes/kubernetes/pull/120100

upodroid commented 1 year ago

/retest

upodroid commented 1 year ago

/retest

upodroid commented 1 year ago

/retest

dims commented 1 year ago

/retest /approve /lgtm

upodroid commented 1 year ago

/assign @michelle192837

dims commented 1 year ago

/retest

upodroid commented 1 year ago

/retest

k8s-ci-robot commented 1 year ago

@upodroid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubetest2-aws-node-e2e 00cf8d7bdec5ca725224c9f862eef8e3808f0da3 link true /test pull-kubetest2-aws-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
upodroid commented 1 year ago

/skip pull-kubetest2-aws-node-e2e

neolit123 commented 1 year ago

https://github.com/kubernetes/kubernetes/pull/120144#issuecomment-1707041256

upodroid commented 1 year ago

@michelle192837 Can you approve this, please? we can ignore the failing AWS test as it is unrelated to this change.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, michelle192837, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [michelle192837] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
michelle192837 commented 1 year ago

Sorry, missed it in emails. Approved!