search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
331 stars 106 forks source link

Support for --cloud-provider and --featuregates #241

Closed dims closed 1 year ago

dims commented 1 year ago

Needed for https://github.com/kubernetes/kubernetes/issues/120367

we have to set both the cloud-provider (to gce) and the disable feature gates (for in-tree cloud provider and in-tree kubelet cred provider)

dims commented 1 year ago

/assign @MushuEE @michelle192837 @xmcqueen @jbpratt

jbpratt commented 1 year ago

/lgtm

dims commented 1 year ago

/retest

dims commented 1 year ago

@jbpratt did you mean to /approve as well? :)

jbpratt commented 1 year ago

/approve

@dims :+1:

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jbpratt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [jbpratt] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment