search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
331 stars 106 forks source link

Fix env var key - should be CLOUD_PROVIDER_FLAG #242

Closed dims closed 1 year ago

dims commented 1 year ago

xref: https://github.com/kubernetes/kubernetes/issues/120367

Almost there w.r.t kubetest2 job. the feature-gates are being passed through, but i got the env var key for the cloud provider wrong.

(see https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-gce-conformance-latest-kubetest2/1698135421877227520/artifacts/cluster-logs/kt2-bd437511-67a4-master/kube-apiserver.log)

dims commented 1 year ago

/assign @michelle192837 @jbpratt @upodroid

dims commented 1 year ago

/retest

jbpratt commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jbpratt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [jbpratt] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment