search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
325 stars 105 forks source link

[cl2] pass through a couple of prometheus parameters #244

Closed dims closed 9 months ago

dims commented 9 months ago

Needed for use by scalability jobs - https://github.com/kubernetes/kops/pull/15963

dims commented 9 months ago

/assign @michelle192837 @jbpratt

jbpratt commented 9 months ago

/lgtm

/hold

k8s-ci-robot commented 9 months ago

@dims: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubetest2-gce-legacy-build-up-down 0f46a3008f816a8a4e1a37bb0945cf8624266b2f link false /test pull-kubetest2-gce-legacy-build-up-down

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dims commented 9 months ago

/skip

https://testgrid.k8s.io/sig-testing-canaries#pull-kubetest2-gce-legacy-build-up-down&width=20 shows that the new job is still under construction

jbpratt commented 9 months ago

/approve /unhold

k8s-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jbpratt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [jbpratt] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment