search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
325 stars 104 forks source link

Fix legacy updown cluster tests #245

Closed upodroid closed 9 months ago

upodroid commented 9 months ago

I wanted to amend kube-up clusters to pick the latest image in an image family instead of using a hardcoded image.

Turns out it is a messy change: https://github.com/kubernetes/kubernetes/pull/120144

/cc @jbpratt @michelle192837

dims commented 9 months ago

/approve /lgtm

/assign @michelle192837 @jbpratt

upodroid commented 9 months ago

/retest

known flakes

jbpratt commented 9 months ago

/approve

k8s-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jbpratt, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [jbpratt] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment