search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
325 stars 104 forks source link

Undo client changes and pass env variables to ginkgo runner #247

Closed upodroid closed 9 months ago

upodroid commented 9 months ago

I need to undo the boskos client changes in #234 as it blocks the kubetest2 library from being upgraded.

Details https://github.com/kubernetes-sigs/boskos/pull/173

Also, I need to add extra env variables to the ginkgo process

/cc @dims @michelle192837

upodroid commented 9 months ago

/retest

dims commented 9 months ago

/approve /lgtm /hold until needed, feel free to remove hold @upodroid

upodroid commented 9 months ago

/hold cancel

pending approve from @michelle192837

k8s-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, michelle192837, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [michelle192837] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment