Configure ginkgo to look for packages in rundir by default

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.

Apache License 2.0

325 stars 105 forks source link

Configure ginkgo to look for packages in rundir by default #249

Closed upodroid closed 8 months ago

upodroid commented 9 months ago

If you pass --use-built-binaries, ginkgo looks for kubectl at the root of the pwd instead of _rundir/RUN_ID/kubectl

I1013 20:23:03.280737   84443 ginkgo.go:141] Using kubeconfig at /root/.kube/config
F1013 20:23:03.280795   84443 tester.go:469] failed to run ginkgo tester: failed to validate pre-built binary kubectl (checked at "/home/prow/go/src/k8s.io/kubernetes/kubectl"): stat kubectl: no such file or directory

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kops/16018/pull-kops-kubernetes-e2e-ubuntu-gce-build/1712916991666294784/build-log.txt

Part of https://github.com/kubernetes/kops/pull/16018

upodroid commented 9 months ago

/assign @michelle192837

verified ginkgo is running binaries from the right place in the gce-legacy job

dims commented 8 months ago

/approve /lgtm

/assign @michelle192837 @xmcqueen @jbpratt

jbpratt commented 8 months ago

/approve

k8s-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jbpratt, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [jbpratt] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment